Display % of points granted by the checker when partially scoring#301
Merged
MasloMaslane merged 6 commits intosio2project:masterfrom Mar 2, 2026
Merged
Display % of points granted by the checker when partially scoring#301MasloMaslane merged 6 commits intosio2project:masterfrom
MasloMaslane merged 6 commits intosio2project:masterfrom
Conversation
DietPawel
requested changes
Dec 7, 2023
Contributor
DietPawel
left a comment
DietPawel
left a comment
There was a problem hiding this comment.
Hey, thank you for delivering a PR. Did You tested the translations?
I tried testing it and it seems that when You change user's language the comment is not reflected.
I believe that, this string "Granted...." is saved during judging of the problem and there is no access to user's language preferences there.
I might have clicked something wrong though.
twalen
previously approved these changes
Dec 20, 2023
DietPawel
requested changes
Dec 20, 2023
DietPawel
changed the title
DietPawel
changed the title
Contributor
|
CC: @Kostero @craniac-swistak |
twalen
previously approved these changes
Apr 3, 2024
MasloMaslane
force-pushed
the
issue288
branch
from
8ad323e to
c3449d5
Compare
|
twalen
approved these changes
Feb 26, 2026
sylwia-sapkowska
pushed a commit
that referenced
this pull request
Mar 4, 2026
* Added result_percentage * Added migration * Added bold to partial score % * Result percentage as fractions.Fraction * Fix migrations * Fix: Migrations --------- Co-authored-by: Mateusz Masiarz <[email protected]> Co-authored-by: Iteron-dev <[email protected]>
sylwia-sapkowska
added a commit
that referenced
this pull request
Mar 11, 2026
* Added partial scoring display in the testing report * Extended comments with information about half time limit exceeded * Extended comments with information about half time limit exceeded * Added helper controller functions to identify contests with linear thresholds, improved comment display after half tl exceeded * Removed try-excepts * Updated unit tests * Display % of points granted by the checker when partially scoring (#301) * Added result_percentage * Added migration * Added bold to partial score % * Result percentage as fractions.Fraction * Fix migrations * Fix: Migrations --------- Co-authored-by: Mateusz Masiarz <[email protected]> Co-authored-by: Iteron-dev <[email protected]> * Unified displaying style * Fixed tests * Fixes from Ruff --------- Co-authored-by: SZonkil <[email protected]> Co-authored-by: Mateusz Masiarz <[email protected]> Co-authored-by: Iteron-dev <[email protected]>
sylwia-sapkowska
added a commit
that referenced
this pull request
Mar 17, 2026
* Added partial scoring display in the testing report * Extended comments with information about half time limit exceeded * Extended comments with information about half time limit exceeded * Added helper controller functions to identify contests with linear thresholds, improved comment display after half tl exceeded * Removed try-excepts * Updated unit tests * Display % of points granted by the checker when partially scoring (#301) * Added result_percentage * Added migration * Added bold to partial score % * Result percentage as fractions.Fraction * Fix migrations * Fix: Migrations --------- Co-authored-by: Mateusz Masiarz <[email protected]> Co-authored-by: Iteron-dev <[email protected]> * Unified displaying style * Fixed tests * Fixes from Ruff --------- Co-authored-by: SZonkil <[email protected]> Co-authored-by: Mateusz Masiarz <[email protected]> Co-authored-by: Iteron-dev <[email protected]>
Jankwi
pushed a commit
to Jankwi/oioioi
that referenced
this pull request
Mar 18, 2026
* Added partial scoring display in the testing report * Extended comments with information about half time limit exceeded * Extended comments with information about half time limit exceeded * Added helper controller functions to identify contests with linear thresholds, improved comment display after half tl exceeded * Removed try-excepts * Updated unit tests * Display % of points granted by the checker when partially scoring (sio2project#301) * Added result_percentage * Added migration * Added bold to partial score % * Result percentage as fractions.Fraction * Fix migrations * Fix: Migrations --------- Co-authored-by: Mateusz Masiarz <[email protected]> Co-authored-by: Iteron-dev <[email protected]> * Unified displaying style * Fixed tests * Fixes from Ruff --------- Co-authored-by: SZonkil <[email protected]> Co-authored-by: Mateusz Masiarz <[email protected]> Co-authored-by: Iteron-dev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of translation is required
Closes #288